This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(alert): use interpolation for type attribute #1460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I've forked and used type: @ as that seems more relevant to my usage requirements..(with added sanity checking), I tend to see the alert types as semi-constants (with a possibility to update) |
|
@bekos @chrisirhc OK, I got you guys. And I totally agree with @chrisirhc that default should go to the template. |
|
@pkozlowski-opensource I will fix for 1.2 before. About the |
|
@bekos ok, let's do this! |
|
@pkozlowski-opensource ping :-) |
ghost
assigned 
BREAKING CHANGE: Use interpolation for type attribute.
Before:
<alert type="'info'" ...></alert >
or
<alert type="alert.type" ...></alert >
After:
<alert type="info" ...></alert >
or
<alert type="{{alert.type}}" ...></alert >
jdbeutel
added a commit
to jdbeutel/ics699-bendy
that referenced
this pull request
May 23, 2014
The update includes this breaking change: angular-ui/bootstrap#1460 so I had to change the alert type attribute to interpolated. I made the same change to bendy-alert-icon for consistency. I did not include the update of the template-less versions, because I'm not sure if I am going to use them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.